Rust clippy172 v2 #9433
Closed
Rust clippy172 v2 #9433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
WARNING:
Pipeline 15820 |
Includes using the right prototype for C SRepCatGetByShortname
cf https://docs.rs/bitflags/latest/bitflags/#zero-bit-flags As warned by clippy 1.72.0
catenacyber
force-pushed
the
rust-clippy172-v2
branch
from
1b62606
to
c2b7439
Compare
victorjulien
approved these changes
Sep 4, 2023
|
Information: QA ran without warnings. Pipeline 15821 |
Merged
|
Merged in #9438, thanks! |
Not the first time we've hit an ARM issue. Should we try to get one in public CI? |
Was just reading about self-hosted runners, and it seems github advises against using them in public repos for security reasons: https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners#self-hosted-runner-security Perhaps a setup more like our qalab jobs would make more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None
Describe changes:
#9418 with better fix for ARM where
charis unsigned